-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache_free: could not destroy w_lock! #174
Comments
Which distro are you using, and which version of that distro are you using? Could I potentially access the server you are using? |
Hello, Unfortunately, the server contains private documents, so I cannot share it. Additionally, I’m open to recompiling the code with debug traces if that would be helpful. For context, the cache is written to an XFS filesystem (though I’m not sure if that detail is relevant). I’ve reviewed #91 and #126. It’s certainly not fun, but would it be possible to handle these errors as non-fatal for the application? Specifically, I’m wondering if it’s necessary to crash the entire process due to a failure in handling a cache file. |
I guess you could, but IMHO failing to destroy a lock indicates a serious issue, possibly some form of memory leak. It might be safer to terminate the program. It is better for you to run the program with cache system turned off. The man page for
What do you mean by "debug traces"? Please give 3aaf5a2 a try. I re-order some of the error messages, so it would print an error before calling If you want, in your local copy, at this line here https://github.com/fangfufu/httpdirfs/blob/master/src/log.h#L23, please add |
Hello, i have just tested the last master version with your commits
|
Apologies, I read the man pages wrong. I thought it would set the errno, but I think that's not the case and it returns error code directly. Please try 614b9d8. |
By the way, where did |
Retested :
|
More logs : Error req_size != recv, req_size: 8388608, recv: 8388608 is suspicious. Also :
|
Thanks, this log is helpful. Btw to resolve the crash for now, you can try running httpdirfs in single threaded mode, or turn off the cache system. I am looking into your log right now. |
Hi, please try out 6cd006c. I improved some of the error messages. Please post a longer log. I want to see when https://github.com/fangfufu/httpdirfs/blob/master/src/cache.c#L945 gets called. It looks like the lock is being prematurely destroyed. Something is holding the lock open. |
Hello, here we go !
|
Hello @fangfufu, let me know if you need additional logs or any specific tests. |
More log ( with cache log traces )
|
I am in the middle of house moving, so I won't have much time to work for this in the next few weeks. In the mean time please turn off the cache system. It should work fine. From a quick look, I can't figure out why
This was mentioned in the comment from a week ago: #174 (comment). If you do that, there will be more messages about when |
Hello @fangfufu , I hope your move is going well. No worries, no one is in a rush.
|
Okat this new log is far more useful. I will have a look over the weekend. I am still in the process of cleaning my old flat and unpacking. I will only have time to work on this project when I want to relax. :/ I /need/ to return the key for my old flat next Monday... |
You can see here that |
It looks to me that Well, thanks for reporting this bug, I find it surprising that nobody has triggered this before. What distro is your client running again? |
Just to clarify, this has got nothing to do with your server, this has got to do with your client. It is my implementation's problem. |
Okay, please try this: 36b5b44 Please enable all the debug features I mentioned previous. Please note that this revision might just hang. It might not be working correctly. But do let me know how it performs. |
Hello @fangfufu, I'm heavily testing under Ubuntu 23 ( client ) First error when the backend is returning a bad receiving size : -2.
Second error, more cache related :
|
The first error is related to #175, I agree it should really be fixed. |
Sorry, I am just really busy with my personal life. I will get this sorted when I have some time. |
Hello,
This error occurs quite randomly, often after a few minutes of use when I open a new file.
After that the process just crash and i have to relaunch.
The text was updated successfully, but these errors were encountered: