Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add pod name to dc project label #110

Closed
wants to merge 1 commit into from
Closed

chore: add pod name to dc project label #110

wants to merge 1 commit into from

Conversation

neezer
Copy link

@neezer neezer commented Sep 9, 2020

Adds the pod name to the Docker Compose project name. This completely eliminates the orphaned container warning messages for me, though I don't know all the ramifications of this change. Basic commands like up, status, stop, & rm all seem to work.

One effect (drawback?) is that by default a new network will be created for each pod, unless one changes the pod definitions to use a manually-created external network—which is what I did. IMO this is something that should be Cage's responsibility, but I didn't see any code path specific to network creation, so I guess that would be a new feature.

Apologies for any newbie mistakes: my only experience with Rust has been reading the Rust book yesterday.

closes #108


I'm seeing lots of cargo clippy errors about imports that shouldn't have been affected by my changes, and I don't see any such errors in master. What's up with that?

@emk
Copy link
Contributor

emk commented Sep 13, 2020

Thank you for the suggestion!

Unfortunately, I believe that this change would break the ability of services in different pods to access each other over the network, which is a very important cage feature that Faraday uses heavily to communicate between front-end services and internal services.

@neezer
Copy link
Author

neezer commented Sep 14, 2020

Unfortunately, I believe that this change would break the ability of services in different pods to access each other over the network, which is a very important cage feature that Faraday uses heavily to communicate between front-end services and internal services.

That’s what I mentioned in my PR description, when I said

One effect (drawback?) is that by default a new network will be created for each pod, unless one changes the pod definitions to use a manually-created external network—which is what I did. IMO this is something that should be Cage's responsibility, but I didn't see any code path specific to network creation, so I guess that would be a new feature.

If cage took responsibility for network creation instead of relying on the Docker Compose default behavior, then we could preserve the original behavior that cage provides now without any additional effort on behalf of the user, while still making projects pod-specific.

@neezer neezer closed this Mar 2, 2021
@neezer neezer deleted the neezer/project-name branch March 2, 2021 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker warnings about orphan containers
2 participants