chore: add pod name to dc project label #110
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the pod name to the Docker Compose project name. This completely eliminates the orphaned container warning messages for me, though I don't know all the ramifications of this change. Basic commands like
up
,status
,stop
, &rm
all seem to work.One effect (drawback?) is that by default a new network will be created for each pod, unless one changes the pod definitions to use a manually-created external network—which is what I did. IMO this is something that should be Cage's responsibility, but I didn't see any code path specific to network creation, so I guess that would be a new feature.
Apologies for any newbie mistakes: my only experience with Rust has been reading the Rust book yesterday.
closes #108
I'm seeing lots of
cargo clippy
errors about imports that shouldn't have been affected by my changes, and I don't see any such errors inmaster
. What's up with that?