Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

given a job id, hard to find datum and therefore error via http #32

Open
seamusabshere opened this issue Dec 15, 2021 · 5 comments
Open

Comments

@seamusabshere
Copy link
Member

querying /jobs/X won't give you datum ids, but that's the only way to get errors

@emk
Copy link
Contributor

emk commented Dec 15, 2021

That's an excellent point! Would Jess be interested in taking lead on this?

@emk
Copy link
Contributor

emk commented Dec 15, 2021

We might want to add /jobs/$ID/datums or something of the sort, because GET /jobs/$ID is already used internally, I believe.

@seamusabshere
Copy link
Member Author

it might be nice to just inline the datums into the job response

@emk
Copy link
Contributor

emk commented Dec 16, 2021

@seamusabshere The HTTP REST API is also used internally, and I'd want to make sure that adding extra data to the job response didn't add extra load internally when jobs are actually running. When you have 350+ clients all hitting the db, you need to be careful about this stuff. :-)

@emk
Copy link
Contributor

emk commented Dec 27, 2021

We should address both this and the other issues discussed in #28 together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants