Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove spruceid/siwe in favor of viem's implementation #183

Open
hiendaovinh opened this issue Aug 13, 2024 · 1 comment
Open

Remove spruceid/siwe in favor of viem's implementation #183

hiendaovinh opened this issue Aug 13, 2024 · 1 comment
Labels

Comments

@hiendaovinh
Copy link

hiendaovinh commented Aug 13, 2024

What is the bug?
To use AuthKit, we have to polyfill Buffer in order to workaround this problem.
Cannot read properties of undefined (reading 'isBuffer')

image

While this could be handled with little effort of polyfill, I suggest that we move to a better implementation with https://viem.sh/docs/siwe/utilities/createSiweMessage.
This will result in less dependencies, less polyfill and better ts support.

Will happy to craft a pull request if needed.

@hiendaovinh
Copy link
Author

We could take one more step and use viem instead of ethers for further reducing of dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant