Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create channel init on button press and not on component mount #216

Open
andrei0x309 opened this issue Aug 22, 2024 · 0 comments
Open

Create channel init on button press and not on component mount #216

andrei0x309 opened this issue Aug 22, 2024 · 0 comments
Labels

Comments

@andrei0x309
Copy link
Contributor

What is the bug?
So the issue now is that the channel initiation request is made as soon as the component mounts, that ok for most cases, but some websites do component remount and will create more than one channel init which will waste resources.

I think it is better to do it how Privy does it, they only open channel initiation when the farcaster button is pressed.

This will resolve cases when the component is re-mounted by poor code, and will also resolve the case of not creating that request if the user will not press the button, because who knows maybe he doesn't have one to log in at that point in time.

How can it be reproduced? (optional)
For example, visit https://beta.buoy.club/login ATM and check the network tab.
Screenshot of issue:

image

Additional context (optional)
I think this is low-priority but is also maybe low effort to solve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant