You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What is the bug?
So the issue now is that the channel initiation request is made as soon as the component mounts, that ok for most cases, but some websites do component remount and will create more than one channel init which will waste resources.
I think it is better to do it how Privy does it, they only open channel initiation when the farcaster button is pressed.
This will resolve cases when the component is re-mounted by poor code, and will also resolve the case of not creating that request if the user will not press the button, because who knows maybe he doesn't have one to log in at that point in time.
How can it be reproduced? (optional)
For example, visit https://beta.buoy.club/login ATM and check the network tab.
Screenshot of issue:
Additional context (optional)
I think this is low-priority but is also maybe low effort to solve.
The text was updated successfully, but these errors were encountered:
What is the bug?
So the issue now is that the channel initiation request is made as soon as the component mounts, that ok for most cases, but some websites do component remount and will create more than one channel init which will waste resources.
I think it is better to do it how Privy does it, they only open channel initiation when the farcaster button is pressed.
This will resolve cases when the component is re-mounted by poor code, and will also resolve the case of not creating that request if the user will not press the button, because who knows maybe he doesn't have one to log in at that point in time.
How can it be reproduced? (optional)
For example, visit https://beta.buoy.club/login ATM and check the network tab.
Screenshot of issue:
Additional context (optional)
I think this is low-priority but is also maybe low effort to solve.
The text was updated successfully, but these errors were encountered: