Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine SAVE_IP and SAVE_CURRENT_IP into a new uop #624

Closed
gvanrossum opened this issue Sep 10, 2023 · 1 comment
Closed

Combine SAVE_IP and SAVE_CURRENT_IP into a new uop #624

gvanrossum opened this issue Sep 10, 2023 · 1 comment

Comments

@gvanrossum
Copy link
Collaborator

See #621 (comment):

Now, there's an explicit SAVE_CURRENT_IP in some macros (before every _POP_FRAME and _PUSH_FRAME). That's because it also acts as a flag for the code generator, which, combined with the preceding SAVE_IP, makes it effectively save a pointer to the next instruction (which is what's needed by the frame push/pop uops). But there's so much special-casing here that we might as well either introduce a new uop for the combined special effects or special-case _POP_FRAME and _PUSH_FRAME.

Also rename SAVE_IP to SET_IP (from the same issue).

@gvanrossum
Copy link
Collaborator Author

Sorry, meant to create this in cpython. See python/cpython#109214.

@gvanrossum gvanrossum closed this as not planned Won't fix, can't repro, duplicate, stale Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant