You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have included information about relevant versions
I have verified that the issue persists when using the master branch of Faust.
Steps to reproduce
Configure App with a redis cache and a TypeError will be raised. This is due to python/cpython#86558 where the loop parameter was removed from asyncio.open_connection in Python 3.10+. aredis was a port of redis-py for async functionality; however, redis-py now includes that functionality natively.
Additionally, aredis is unmaintained and has not been updated in years.
Expected behavior
No exception.
Actual behavior
TypeError was raised.
Full traceback
Traceback (most recent call last):
File "/home/dev-user/.cache/pypoetry/virtualenvs/worker-9TtSrW0h-py3.12/lib/python3.12/site-packages/aredis/connection.py", line 415, in connectawaitself._connect()
File "/home/dev-user/.cache/pypoetry/virtualenvs/worker-9TtSrW0h-py3.12/lib/python3.12/site-packages/aredis/connection.py", line 594, in _connect
reader, writer =await exec_with_timeout(
^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/dev-user/.cache/pypoetry/virtualenvs/worker-9TtSrW0h-py3.12/lib/python3.12/site-packages/aredis/connection.py", line 39, in exec_with_timeoutreturnawait asyncio.wait_for(coroutine, timeout)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/asyncio/tasks.py", line 520, in wait_forreturnawait fut
^^^^^^^^^
File "/usr/local/lib/python3.12/asyncio/streams.py", line 48, in open_connection
transport, _ =await loop.create_connection(
^^^^^^^^^^^^^^^^^^^^^^^TypeError: BaseEventLoop.create_connection() got an unexpected keyword argument 'loop'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/home/dev-user/.cache/pypoetry/virtualenvs/worker-9TtSrW0h-py3.12/lib/python3.12/site-packages/aredis/client.py", line 155, in execute_commandawait connection.send_command(*args)
File "/home/dev-user/.cache/pypoetry/virtualenvs/worker-9TtSrW0h-py3.12/lib/python3.12/site-packages/aredis/connection.py", line 486, in send_commandawaitself.connect()
File "/home/dev-user/.cache/pypoetry/virtualenvs/worker-9TtSrW0h-py3.12/lib/python3.12/site-packages/aredis/connection.py", line 417, in connectraiseConnectionError()
aredis.exceptions.ConnectionError
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/home/dev-user/.cache/pypoetry/virtualenvs/worker-9TtSrW0h-py3.12/lib/python3.12/site-packages/aredis/connection.py", line 415, in connectawaitself._connect()
File "/home/dev-user/.cache/pypoetry/virtualenvs/worker-9TtSrW0h-py3.12/lib/python3.12/site-packages/aredis/connection.py", line 594, in _connect
reader, writer =await exec_with_timeout(
^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/dev-user/.cache/pypoetry/virtualenvs/worker-9TtSrW0h-py3.12/lib/python3.12/site-packages/aredis/connection.py", line 39, in exec_with_timeoutreturnawait asyncio.wait_for(coroutine, timeout)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/asyncio/tasks.py", line 520, in wait_forreturnawait fut
^^^^^^^^^
File "/usr/local/lib/python3.12/asyncio/streams.py", line 48, in open_connection
transport, _ =await loop.create_connection(
^^^^^^^^^^^^^^^^^^^^^^^TypeError: BaseEventLoop.create_connection() got an unexpected keyword argument 'loop'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/home/dev-user/.cache/pypoetry/virtualenvs/worker-9TtSrW0h-py3.12/lib/python3.12/site-packages/mode/worker.py", line 277, in execute_from_commandlineself.loop.run_until_complete(self._starting_fut)
File "/usr/local/lib/python3.12/asyncio/base_events.py", line 687, in run_until_completereturn future.result()
^^^^^^^^^^^^^^^
File "/home/dev-user/.cache/pypoetry/virtualenvs/worker-9TtSrW0h-py3.12/lib/python3.12/site-packages/mode/services.py", line 830, in startawaitself._default_start()
File "/home/dev-user/.cache/pypoetry/virtualenvs/worker-9TtSrW0h-py3.12/lib/python3.12/site-packages/mode/services.py", line 837, in _default_startawaitself._actually_start()
File "/home/dev-user/.cache/pypoetry/virtualenvs/worker-9TtSrW0h-py3.12/lib/python3.12/site-packages/mode/services.py", line 861, in _actually_startawait child.maybe_start()
File "/home/dev-user/.cache/pypoetry/virtualenvs/worker-9TtSrW0h-py3.12/lib/python3.12/site-packages/mode/services.py", line 889, in maybe_startawaitself.start()
File "/home/dev-user/.cache/pypoetry/virtualenvs/worker-9TtSrW0h-py3.12/lib/python3.12/site-packages/mode/services.py", line 830, in startawaitself._default_start()
File "/home/dev-user/.cache/pypoetry/virtualenvs/worker-9TtSrW0h-py3.12/lib/python3.12/site-packages/mode/services.py", line 837, in _default_startawaitself._actually_start()
File "/home/dev-user/.cache/pypoetry/virtualenvs/worker-9TtSrW0h-py3.12/lib/python3.12/site-packages/mode/services.py", line 861, in _actually_startawait child.maybe_start()
File "/home/dev-user/.cache/pypoetry/virtualenvs/worker-9TtSrW0h-py3.12/lib/python3.12/site-packages/mode/services.py", line 889, in maybe_startawaitself.start()
File "/home/dev-user/.cache/pypoetry/virtualenvs/worker-9TtSrW0h-py3.12/lib/python3.12/site-packages/mode/services.py", line 830, in startawaitself._default_start()
File "/home/dev-user/.cache/pypoetry/virtualenvs/worker-9TtSrW0h-py3.12/lib/python3.12/site-packages/mode/services.py", line 837, in _default_startawaitself._actually_start()
File "/home/dev-user/.cache/pypoetry/virtualenvs/worker-9TtSrW0h-py3.12/lib/python3.12/site-packages/mode/services.py", line 854, in _actually_startawaitself.on_start()
File "/home/dev-user/.cache/pypoetry/virtualenvs/worker-9TtSrW0h-py3.12/lib/python3.12/site-packages/faust/web/cache/backends/redis.py", line 115, in on_startawaitself.connect()
File "/home/dev-user/.cache/pypoetry/virtualenvs/worker-9TtSrW0h-py3.12/lib/python3.12/site-packages/faust/web/cache/backends/redis.py", line 121, in connectawaitself.client.ping()
File "/home/dev-user/.cache/pypoetry/virtualenvs/worker-9TtSrW0h-py3.12/lib/python3.12/site-packages/aredis/commands/connection.py", line 20, in pingreturnawaitself.execute_command('PING')
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/dev-user/.cache/pypoetry/virtualenvs/worker-9TtSrW0h-py3.12/lib/python3.12/site-packages/aredis/client.py", line 165, in execute_commandawait connection.send_command(*args)
File "/home/dev-user/.cache/pypoetry/virtualenvs/worker-9TtSrW0h-py3.12/lib/python3.12/site-packages/aredis/connection.py", line 486, in send_commandawaitself.connect()
File "/home/dev-user/.cache/pypoetry/virtualenvs/worker-9TtSrW0h-py3.12/lib/python3.12/site-packages/aredis/connection.py", line 417, in connectraiseConnectionError()
aredis.exceptions.ConnectionError
Checklist
master
branch of Faust.Steps to reproduce
Configure App with a redis cache and a TypeError will be raised. This is due to python/cpython#86558 where the
loop
parameter was removed fromasyncio.open_connection
in Python 3.10+.aredis
was a port ofredis-py
for async functionality; however,redis-py
now includes that functionality natively.Additionally,
aredis
is unmaintained and has not been updated in years.Expected behavior
No exception.
Actual behavior
TypeError was raised.
Full traceback
The
aredis
code causing the issue:Versions
The text was updated successfully, but these errors were encountered: