Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python 3.12: imp is deprecated in favor of importlib #259

Open
dirks opened this issue May 7, 2024 · 3 comments
Open

python 3.12: imp is deprecated in favor of importlib #259

dirks opened this issue May 7, 2024 · 3 comments

Comments

@dirks
Copy link

dirks commented May 7, 2024

In src/ansiblecmdb/render.py imp is used, which has been deprecated in python 3.4 and removed in python 3.12, see https://docs.python.org/3.12/whatsnew/3.12.html#imp

import imp
[…]
    def _render_py(self, hosts, vars={}):
        module = imp.load_source('r', self.tpl_file)
        return module.render(hosts, vars=vars, tpl_dirs=self.tpl_dirs)
@dirks dirks mentioned this issue May 15, 2024
@cwegener
Copy link

This issue's title is a bit misleading. The title should be cannot run ansible-cmdb with Python 3.12 and the actual error message should be included as well (ModuleNotFoundError: No module named 'imp')

@jpoggi
Copy link

jpoggi commented Oct 11, 2024

Hi,

ansible-cmd still does not work in a virtualenv with Python 3.12.7.

Here is my virtualenv packages.txt

ansible==10.4.0
ansible-lint==24.9.2
ansible-cmdb==1.31
dnspython
netaddr
jmespath
powerline-status
powerline-gitstatus

And here is the error message when I try to convert the files on html.

ansible-cmdb -t html_fancy_split -p local_js=0 out/
Traceback (most recent call last):
  File "/home/user/Ansible/bin/../lib/ansiblecmdb/ansible-cmdb.py", line 22, in <module>
    import ansiblecmdb.render as render
  File "/home/user/Ansible/lib/python3.12/site-packages/ansiblecmdb/render.py", line 2, in <module>
    import imp
ModuleNotFoundError: No module named 'imp'

Is this suppose to be fix, or any workaround is provided ?

Thanks a lot.

@jpoggi
Copy link

jpoggi commented Nov 10, 2024

Up !
:-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants