Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow extending Codec #504

Open
cyber-barrista opened this issue Jan 12, 2023 · 2 comments
Open

Allow extending Codec #504

cyber-barrista opened this issue Jan 12, 2023 · 2 comments

Comments

@cyber-barrista
Copy link

I have a custom encoding/decoding logic but would still like to take advantage of other fd4s/vulcan goodies. Currently, it is not very possible (aside from maybe using deprecated Codec.instance) to make your own Codec since it is sealed. Are there any issues you can foresee with custom implementations?
@bplommer
Copy link
Member

The reason we deprecated Codec.instance is so that Codec can be changed to an algebraic data type as set out in #437 . Can you say a bit about your use case for this?

@lucaviolanti
Copy link
Contributor

We had a use case for other instances of Codec (for types supported by the Avro spec: instant micros and local datetime millis) and we just created a PR for them.

This was referenced Jun 23, 2023
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lucaviolanti @bplommer @cyber-barrista