Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wagtail 6: Switch News-and-Updates and Authors sidebar-menus from Snippets to more fitting Viewset options #6614

Open
3 tasks
johnnyporkchops opened this issue Dec 30, 2024 · 0 comments

Comments

@johnnyporkchops
Copy link
Contributor

johnnyporkchops commented Dec 30, 2024

Blocking issue:
#6416

Summary

  • In this commit, we were forced to temporarily switch the News and Updates and Authors sidebar-menu items from the ModelAdmin to Snippets because of issues with the ModelAdmin. (Since wagtail.contrib.modeladmin is an installed package in maintenance-mode that will not receive further updates, we removed it from settings/base.py)
    • Neither of these are Snippets and it would be confusing to editors to keep them in the Sniippet admin area
  • Prior to to Wagrail 6.1, Snippets was the suggested temporary option. Once we have upgraded, more fitting Viewset options are available for both.

Technical steps:*

  • Switch News and Updates sidebar-menu from Snippets to PageListingViewsets in a ViewSetGroup
  • Switch Authors sidebar-menu to ModelViewset
  • We can remove index_custom_button.html, this was a fix to avoid the "choose a parent" button that caused the page timeouts in production. In Wagtail 6, "choose a parent" does not timeout because it presents a page explorer instead of trying to list all 10,000+ pages in the tree.

*John has a saved version of wagtail_hooks.py with most of the necessary changes

Completion Criteria:

  • [ ]
  • [ ]
@johnnyporkchops johnnyporkchops changed the title Switch Wagtail News and Updates menu from Snippets to PageListingViewsets Switch Wagtail News and Updates menu from Snippets to PageListingViewsets and Authors to ModelViewet Jan 2, 2025
@johnnyporkchops johnnyporkchops changed the title Switch Wagtail News and Updates menu from Snippets to PageListingViewsets and Authors to ModelViewet Switch Wagtail News and Updates menu from Snippets to PageListingViewsets and Authors to ModelViewset Jan 2, 2025
@johnnyporkchops johnnyporkchops changed the title Switch Wagtail News and Updates menu from Snippets to PageListingViewsets and Authors to ModelViewset Wagtail 6: Switch News-and-Updates and Authors sidebar-menus from Snippets to more fitting Viewset options Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

1 participant