Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: (IntelliJ Plugin) Make use of Dart 3 class modifiers #3911

Closed
kputh opened this issue Jul 25, 2023 · 4 comments · Fixed by #4104
Closed

feat: (IntelliJ Plugin) Make use of Dart 3 class modifiers #3911

kputh opened this issue Jul 25, 2023 · 4 comments · Fixed by #4104
Assignees
Labels
enhancement New feature or request extension This issue relates to bloc extensions

Comments

@kputh
Copy link

kputh commented Jul 25, 2023

Description

Dart 3 introduced new class modifiers, and the examples in the bloc naming conventions make use of the sealed and final class modifiers. The event and state classes generated by the bloc plugin for IntelliJ IDEA deviate from the official documentation by not using these new class modifiers.

Desired Solution

Offer the option to have the bloc plugin for IntelliJ IDEA generate events and states for Dart 3 using the sealed and final class modifiers.

@felangel
Copy link
Owner

Hi 👋
I’m working on this atm. I’m wrapping up the bricks (#3907) and will adjust the plugins next 👍

@felangel felangel self-assigned this Jul 25, 2023
@felangel felangel added enhancement New feature or request extension This issue relates to bloc extensions labels Jul 25, 2023
@8thgencore
Copy link

@felangel Good afternoon, when to wait for the update?

@felangel
Copy link
Owner

felangel commented Nov 7, 2023

@8thgencore sorry for the delay! Planning to get to this in the next few days 👍

@donghyeon
Copy link

donghyeon commented Jan 5, 2024

Apologies for my comment below. I've realized that the registration procedure differs in that it doesn't simply select one option above all sealed event classes. Therefore, please disregard my earlier comment as it was incorrect. Though, I think the exhaustive search can still find its application somewhere within this library.

Are there plans to modify the way handlers are registered in Bloc, particularly in light of the recent updates regarding exhaustive searches on sealed classes? Of course, the current on method works flawlessly. However, I believe integrating the registration process with the basic Dart 3 syntax might be more intuitive and familiar to newcomers to the Bloc library, compared to using a custom method.

@felangel felangel linked a pull request Mar 13, 2024 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request extension This issue relates to bloc extensions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants