Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

addpkg: obs-studio #2776

Merged
merged 1 commit into from
Oct 14, 2023
Merged

addpkg: obs-studio #2776

merged 1 commit into from
Oct 14, 2023

Conversation

r-value
Copy link
Collaborator

@r-value r-value commented Jun 30, 2023

char is unsigned on RISC-V and it's impl-defined for char to be signed or unsigned. Ensuring utf8_char_t to be signed to make comparison with zero works.

Xeonacid
Xeonacid reviewed Jun 30, 2023
View reviewed changes
Copy link
Collaborator

@Xeonacid Xeonacid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch test is failing.

@r-value
Copy link
Collaborator Author

r-value commented Oct 13, 2023

Fixed and follows upstream PR obsproject/obs-studio#9184

@felixonmars felixonmars merged commit d511da3 into felixonmars:master Oct 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xeonacid Xeonacid Xeonacid left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@r-value @Xeonacid @felixonmars