Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation #10

Open
rpharrison opened this issue Jan 22, 2014 · 1 comment
Open

Add documentation #10

rpharrison opened this issue Jan 22, 2014 · 1 comment

Comments

@rpharrison
Copy link

Your code is really useful to me and I've been attempting to use it with https://github.com/luan/ember-facebook but without any success.

Perhaps you'd consider adding basic instructions on how to properly load additional libraries and use mixins?

@kolotyluk
Copy link

Yes, while I like the way the project is structured, there are many important details missing, that could be filled in with some useful comments to help get 'on-board' easier. For example, in main.js

(function(root) {
    require(["config"], function(config) {
        requirejs.config(config);
        require(["App", "ember"], function(App, Ember) {
            var app_name = config.app_name || "App";
            root[app_name] = App = Ember.Application.create(App);
        });
    });
})(this);

Presumably this function is being called via

    <script data-main="./scripts/main" src="./scripts/libs/requirejs/2.1.2/require.js"></script>

and root is being passed in as this - but, it's not really clear to the beginner why you are doing things this way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants