Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ACF Pro from examples now that they support native Composer integration? #48

Open
jeffwidman opened this issue Jul 31, 2023 · 5 comments

Comments

@jeffwidman
Copy link

Want to remove ACF Pro from your examples now that they natively support composer integration?

@szepeviktor
Copy link
Contributor

szepeviktor commented Jul 31, 2023

Some people prefer proven solutions.
I may be using their Composer repository after a year, or later.

@mcaskill
Copy link
Contributor

I recently contacted ACF Pro's vendor (WPEngine, at the time of writing). Important changes have occurred and more are in the works:

  1. The URL for the ACF Pro example (/index.php?p=pro&a=download&k=***&t=X.Y.Z) is obsolete.
  2. The new URL (/v2/plugins/download?p=pro&k=***&t=X.Y.Z) does not work with Composer (because the server checks the User-Agent for Composer for its Composer repository).
  3. In the coming months, the vendor is changing its API to use server generated single-use URLs.
  4. Even the URLs from the official Composer repository (/v2/plugins/composer_download?p=pro&t=X.Y.Z) will eventually adopt single-use URLs.

@szepeviktor
Copy link
Contributor

@szepeviktor
Copy link
Contributor

@mcaskill
Copy link
Contributor

If its possible to change the user-agent via proxy settings, that will only be practical for the short term. Eventually, the vendor will deploy single-use URLs (à la Easy Digital Downloads) which will require an intermediate request to retrieve the download URL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants