Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some tests to the harware-wallet suite. #107

Open
isaacvr opened this issue Oct 31, 2019 · 0 comments
Open

Add some tests to the harware-wallet suite. #107

isaacvr opened this issue Oct 31, 2019 · 0 comments

Comments

@isaacvr
Copy link

isaacvr commented Oct 31, 2019

Feature description

Make the following tests working for hardware-wallet crypto API

  • TestPubKeyToAddress2
  • TestAddressRoundtrip
  • TestAddressString
  • TestAddressBulk
  • TestDecodeBase58Address
  • TestAddressFromSecKey
  • TestSumSHA256

Describe the solution you'd like
These tests should run from hardware wallet project too.

Additional context
Related to this https://github.com/skycoin/hardware-wallet/issues/84

Possible implementation
Just move them to the *common files and make sure that they are working from hw.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@isaacvr