Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration and/or unit test for recovery device #315

Open
isaacvr opened this issue Oct 31, 2019 · 0 comments
Open

Integration and/or unit test for recovery device #315

isaacvr opened this issue Oct 31, 2019 · 0 comments
Labels
enhancement New feature or request security

Comments

@isaacvr
Copy link
Contributor

isaacvr commented Oct 31, 2019

Feature description

Is required to write some tests to check that device recovery command is working properly.

Is your feature request related to a problem? Please describe.
Currently the device recovery have not any automated test

Describe the solution you'd like
Implement such test

Additional context

https://github.com/skycoin/hardware-wallet/blob/8a2c42f4a79d0deeb3f7bd776b56c126cf7322c8/tiny-firmware/firmware/recovery.c#L430-L447

https://github.com/skycoin/hardware-wallet/blob/8a2c42f4a79d0deeb3f7bd776b56c126cf7322c8/tiny-firmware/firmware/recovery.c#L140-L149

As you can see the device is not sending feedback info about the required next word through the wire, this info is show only in the device screen. You can confirm this looking at the WordRequest protobuf message too.

It's very important to note that you can not add this info to the message because this will break(reveal) the random order for word request, this is an important security issue.

Possible implementation
To be finined

@isaacvr isaacvr added enhancement New feature or request security labels Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request security
Projects
None yet
Development

No branches or pull requests

1 participant