Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BitswapPublicAddresses missing from config default #1587

Closed
7 of 12 tasks
hyunmoon opened this issue Jul 21, 2023 · 0 comments · Fixed by #1588
Closed
7 of 12 tasks

BitswapPublicAddresses missing from config default #1587

hyunmoon opened this issue Jul 21, 2023 · 0 comments · Fixed by #1588
Labels

Comments

@hyunmoon
Copy link

Checklist

  • This is not a question or a support request. If you have any boost related questions, please ask in the discussion forum.
  • This is not a new feature request. If it is, please file a feature request instead.
  • This is not an enhancement request. If it is, please file a improvement suggestion instead.
  • I have searched on the issue tracker and the discussion forum, and there is no existing related issue or discussion.
  • I am running the Latest release, or the most recent RC(release canadiate) for the upcoming release or the dev branch(master), or have an issue updating to any of these.
  • I did not make any code changes to boost.

Boost component

  • boost daemon - storage providers
  • boost client
  • boost UI
  • boost data-transfer
  • boost index-provider
  • Other

Boost Version

boostd version 1.7.3+git.188d5f0

Describe the Bug

BitswapPublicAddresses is missing from the default configuration even though it has been documented here:
https://boost.filecoin.io/bitswap-retrieval#public-mode

boostd config default

  # The libp2p peer id used by booster-bitswap.
  # Run 'booster-bitswap init' to get the peer id.
  # When BitswapPeerID is not empty boostd will:
  # - listen on bitswap protocols on boostd's own peer id and proxy
  # requests to booster-bitswap
  # - advertise boostd's peer id in bitswap records to the content indexer
  # (bitswap clients connect to boostd, which proxies the requests to
  # booster-bitswap)
  # - list bitswap as an available transport on the retrieval transport protocol
  #
  # type: string
  #BitswapPeerID = ""

  # If operating in public mode, in order to announce booster-bitswap as an extended provider, this value must point to a
  # a file containing the booster-bitswap peer id's private key. Can be left blank when operating with protocol proxy.
  #
  # type: string
  #BitswapPrivKeyFile = ""

Logging Information

N/A

Repo Steps

boostd config default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant