Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check ExpectedSealDuration and MaxDealStartDelay for boost deals #1608

Closed
LexLuthr opened this issue Aug 7, 2023 · 1 comment · Fixed by #1609
Closed

Check ExpectedSealDuration and MaxDealStartDelay for boost deals #1608

LexLuthr opened this issue Aug 7, 2023 · 1 comment · Fixed by #1609

Comments

@LexLuthr
Copy link
Collaborator

LexLuthr commented Aug 7, 2023

We are currently not checking these 2 variables within the BasicDealFilters. We must check them or remove the config options from the [Dealmaking] section.
Since, legacy deals are now deprecated, the importance of these filters is higher.
@LexLuthr LexLuthr mentioned this issue Aug 7, 2023
Merged
1 task
@oneforalone
Copy link

oneforalone commented Aug 7, 2023 •
edited
Loading

Are these configures redundant? Cause there are same variables in [LotusDealmaking], moreover, there's [Dealmaking] section in miner's config file. Should i set them both, or just care about [Dealmaking] section of boost?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Boost
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: update deal filter to use ExpectedSealDuration and MaxDealStartDelay filecoin-project/boost
2 participants
@oneforalone @LexLuthr