Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support eth_getBlockReceipts #12429

Open
rvagg opened this issue Sep 4, 2024 · 7 comments · May be fixed by #12478
Open

Support eth_getBlockReceipts #12429

rvagg opened this issue Sep 4, 2024 · 7 comments · May be fixed by #12478
Assignees
Labels
good first issue Good for newcomers

Comments

@rvagg
Copy link
Member

rvagg commented Sep 4, 2024

I think the output of this is the same as eth_getTransactionReceipts but you query for the block number instead of transaction hash and the result is just an array with all of the eth_getTransactionReceipts results.

This is an efficient way to get all details of a tipset rather than querying for all messages and constructing it yourself. Just need to be careful about doing proper de-duplication.

@rvagg rvagg added the good first issue Good for newcomers label Sep 4, 2024
@virajbhartiya
Copy link

I'd Like to work on this

@rjan90
Copy link
Contributor

rjan90 commented Sep 4, 2024

I'd Like to work on this

Awesome, I will assign this ticket to you then @virajbhartiya. Let us know if you need additional pointers to where this should go in code, either here or in the #fil-lotus-dev channel in Slack.

@virajbhartiya
Copy link

Yes sure. Thanks a lot

@virajbhartiya
Copy link

Hey, @rjan90, so just to be clear, we have to implement a function eth_getBlockReceipts that will allow clients to retrieve all transaction receipts from a specific block. So instead of querying for each transaction usingeth_getTransactionReceipt, we query for the block, and it would return an array of all transaction receipts from that block?

@rvagg
Copy link
Member Author

rvagg commented Sep 7, 2024

@virajbhartiya yes, but please do a bit of research on the various forms of Ethereum documentation out there to confirm that eth_getBlockReceipts is precisely that. That's my understanding from a brief bit of research but it would be good to confirm.

@virajbhartiya
Copy link

virajbhartiya commented Sep 11, 2024

@rvagg @rjan90 I have submitted a PR, can you please give it a look

@virajbhartiya
Copy link

Hey @rvagg @rjan90 im having some trouble passing a few tests, could you please help me out with those

@jennijuju jennijuju linked a pull request Sep 13, 2024 that will close this issue
8 tasks
@virajbhartiya virajbhartiya linked a pull request Sep 17, 2024 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: 🔎 Awaiting review
3 participants