Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Cheggaaa's PB from v1 to v3 #12433

Closed
Stebalien opened this issue Sep 4, 2024 · 2 comments · Fixed by #12518
Closed

Update Cheggaaa's PB from v1 to v3 #12433

Stebalien opened this issue Sep 4, 2024 · 2 comments · Fixed by #12518
Assignees
@virajbhartiya
Labels
cleanup good first issue Good for newcomers kind/enhancement Kind: Enhancement

Comments

@Stebalien
Copy link
Member

Version 3 of the progress bar library we use (Cheggaaa's "pb") was released quite a while ago. We should update from gopkg.in/cheggaaa/pb.v1 to github.com/cheggaaa/pb/v3, but will need to handle the breaking API changes.
@Stebalien Stebalien added good first issue Good for newcomers kind/enhancement Kind: Enhancement cleanup labels Sep 4, 2024
@virajbhartiya
Copy link
Member

Can I work on this?

@rvagg
Copy link
Member

rvagg commented Sep 27, 2024

@virajbhartiya yep go for it, this should be fairly straightforward 🤞

@virajbhartiya virajbhartiya mentioned this issue Sep 27, 2024
Merged
Stebalien pushed a commit that referenced this issue Sep 27, 2024
@virajbhartiya
feat(PB): update Cheggaaa's version (#12518)
765dcc2 
Updated the version for Cheggaaa's pb from v1 to v3.

Closes #12433
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@virajbhartiya virajbhartiya

Labels
cleanup good first issue Good for newcomers kind/enhancement Kind: Enhancement
Projects
FilOz
Status: ☑️ Done (Archive)
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(PB): update Cheggaaa's version virajbhartiya/lotus
3 participants
@Stebalien @rvagg @virajbhartiya