Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite checkpointing to use GetTipsetByHeight instead of IsAncestorOf #12475

Open
masih opened this issue Sep 17, 2024 · 0 comments
Open

Rewrite checkpointing to use GetTipsetByHeight instead of IsAncestorOf #12475

masih opened this issue Sep 17, 2024 · 0 comments

Comments

@masih
Copy link
Member

masih commented Sep 17, 2024

As a user I want the chain sync for potentially missing tipsets to be as efficient as possible when checkpointing a tipset. This is because:

  • we cannot checkpoint a tipset unless it is synced, and
  • tipset sync is usually a blocking operation, in that the chances are the normal flow of whatever the sync is used for cannot progress until the missing tipsets are synced and the faster more efficient the sync the better the UX.

The following use the chain index via GetTipsetByHeight instead of chainstore IsAncestorOf to lookup and fill missing tipsets:

  • Syncer.SyncCheckpoint
  • ChainStore.SetCheckpoint

Context: pointed out in this PR review.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
FilOz
Status: 📌 Triage
Milestone
No milestone
Development

No branches or pull requests
1 participant
@masih