Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

Duplicate option defaults #192

Open
elijaharita opened this issue Oct 28, 2023 · 0 comments
Open

Duplicate option defaults #192

elijaharita opened this issue Oct 28, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@elijaharita
Copy link
Contributor

There are currently 2 (3? (4?)) sources of truth for default options - the first is from some of the CLI flags which have default values, and the second is from the newOptions() function. There is also kind of a third source, which is in the comments above each WithXXX option function.

This excessive duplication of default values is a maintenance burden and a potential weird source of bugs. Ideally there should only be one place that default constants are defined.

@elijaharita elijaharita added the enhancement New feature or request label Oct 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant