Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change GET /rounds/meridian/{contract}/{round-index} to be more restful #200

Open
bajtos opened this issue Jan 25, 2024 · 0 comments
Open

Comments

@bajtos
Copy link
Member

bajtos commented Jan 25, 2024

See the discussion in https://www.notion.so/Moving-IPNI-queries-to-Spark-checkers-c58175c0f1c841e6bb82ac44a1472a98?d=66562e2c7ee94dedaf835725fb630abd&pvs=4#22453399ef9d4c3580be125837dcb8c5

would it be more restful to have this be meridian/contracts/{contractId}/rounds/{roundId} ?

Maybe even /meridian/{contract-address}/rounds/{round-id}

will meridian ever have other models exposed through its api? I’m just wondering if it is actually useful to have /contracts in the URL, in case in the future we have something like meridian/tasks/{taskId} or something
if I have a URL that says meridian/1234 im not sure what this value refers to

cc @patrickwoodhead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant