-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub: Update copyright span #16085
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Whatever is easier to maintain |
This comment was marked as outdated.
This comment was marked as outdated.
@0x5bfa do you want me to just make it 2018-present? |
This comment was marked as outdated.
This comment was marked as outdated.
@0x5bfa 'See the LICENSE.' is grammatically incorrect. I recommend 'See the license file', 'See the license file in the root directory' or even just remove the 'See the license' sentence altogether |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Oops, GitHub automatically closed since I wiped the PR clean of commit history. @0x5bfa I'm still working on this though. |
(again) Resolves files-community#16085 (comment)
@yaira2 do you not have a CODEOWNERS file? |
src/Files.Core.SourceGenerator/Extensions/StringBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -1,4 +1,5 @@ | |||
<Project Sdk="Microsoft.NET.Sdk"> | |||
<!-- Copyright (c) 2018-2024 Files Community. Licensed under the MIT License. --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For other reviewers: this is the reason why addition and deletion aren't the same count (newly the header added)
e53688e
to
44f3295
Compare
44f3295
to
cac9073
Compare
I think I should close this - I initially opened this PR because I was worried about the law but I have come to realise that I'm really stupid this PR is absolutely unnecessary. |
Probably someone or I do this when it becomes 2025. |
Yeah. |
Resolved / Related Issues