Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Exiting IrfanView when previewing image located inside archive crashes app #16216

Closed
andrew-james-heard opened this issue Sep 18, 2024 · 13 comments
Labels
needs - additional info Needs more information from the reporter

Comments

@andrew-james-heard
Copy link

Description

open JPG within ZIP then exit -> immediate & silent crash
if I copy the JPG, then alt+cursor up, alt+cursor up, paste, then Enter/ Esc the viewer there is no problems i.e. the JPG is nothing special

Steps To Reproduce

  1. I have a ~600MB ZIP file
  2. selected & pressed Enter
  3. pressed Space to select folder inside
  4. press Enter
  5. there are 101 items in the ZIP
  6. one item is a 300KB JPG
  7. cursor right & press Enter to view JPG (without trouble) - is using IrfanView
  8. press Esc to exit
  9. immediate & silent crash
    It doesn't appear the log file shows anything of much use.

Requirements

Fix crash that occurs

Files Version

3.7.6

Windows Version

23H2

Log File

20240918 1543 debug.log

@yaira2
Copy link
Member

yaira2 commented Sep 18, 2024

press Esc to exit

Esc to in Files?

@yaira2 yaira2 added the needs - additional info Needs more information from the reporter label Sep 18, 2024
@yaira2 yaira2 changed the title crash when exit JPG viewer inside ZIP file Bug: Exiting IrfanView when previewing image located inside archive crashes app Sep 18, 2024
@andrew-james-heard
Copy link
Author

correct

enter ZIP > select/ open JPG with viewer > Esc is naturally assumed to return to Files, but crashes

I just confirmed, it works fine with Windows Explorer

@yaira2
Copy link
Member

yaira2 commented Sep 18, 2024

Does closing the program normally also cause the issue?

@andrew-james-heard
Copy link
Author

if I close the JPG viewer with alt+F4 or task swap back to Files Preview with alt+Tab, Files sometimes still crashes

@yaira2
Copy link
Member

yaira2 commented Sep 19, 2024

Does this happen with any other viewer?

@andrew-james-heard
Copy link
Author

The "Open with" sub-menu doesn't work for the JPG within a ZIP file, so I have no way of knowing. I can't see it has anything to do with the JPG viewer though.

@yaira2
Copy link
Member

yaira2 commented Sep 19, 2024

Closing an external app shouldn't have anything to do with Files. I do wonder if the viewer tries to modify the file upon close. Can you try changing the default viewer from the Settings app?

@andrew-james-heard
Copy link
Author

I changed the default app associated with JPG from IrfanView to GIMP, went thru the same procedure, clicked Enter on the JPG (within the ZIP) and 2s later, even before GIMP was stable, observed Files had silently disappeared from the taskbar.

@yaira2
Copy link
Member

yaira2 commented Sep 30, 2024

Is this still an issue in the preview version? https://files.community/download/preview

@andrew-james-heard
Copy link
Author

just checked with 3.7.9 - all fixed, well done! was there a comment in the change notes? maybe "Fixed an issue with navigating photos on Windows 10."?

@yaira2
Copy link
Member

yaira2 commented Sep 30, 2024

The fix was for a different issue but I was curious if it also resolved this. Thank you for confirming.

@yaira2 yaira2 closed this as completed Sep 30, 2024
@andrew-james-heard
Copy link
Author

While you are there... I have a different issue, but maybe already open/ aware of, so will save me not reporting - sometimes, but only sometimes, when I press Enter on a file (eg. LibreOffice writer .odt or calc .ods) the application takes ages to open. It appears to stall. I discovered if I kill Files.exe from Sysinternals Process Explorer that the application opening resumes. I get the impression Files has temporarily/ incorrectly locked the file. If I open the application from Start menu instead of indirectly by file association, then never a problem. Seems to have started recently. Doesn't happen with Explorer.

@yaira2
Copy link
Member

yaira2 commented Oct 1, 2024

I have a good idea why this is, can you open an issue so we don't lose track?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs - additional info Needs more information from the reporter
Projects
None yet
Development

No branches or pull requests

2 participants