-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File preview is broken in debug mode #4206
Comments
Fyi @winston-de |
@d2dyno1 Thanks for reporting this. |
@winston-de both. |
@d2dyno1 As for the details not showing, I can't reproduce the issue, do you have any other information or a specific file I could test with? |
@d2dyno1 I can't reproduce this issue in v1.4.46. |
@winston-de Sample .mp3 file that neither works: https://drive.google.com/file/d/1jeUUo55WWuHI8ruVwpqtBNSpfx_n7sDC/view?usp=sharing |
@d2dyno1 What version of Files do you have? |
That was the latest commit where the Interaction was removed on |
@yaichenbaum @winston-de Update: This was not caused by #4189. I've cloned the commit before that, and the issue was still present |
@d2dyno1 I'm testing on the latest version of main, and the file works as expected. |
@winston-de "Works on my machine" 😂 |
Yo, even the icons are aligned! |
@d2dyno1 Wait, that was the wrong screenshot |
What? Then why were they aligned in the previous one? 😆 |
@yaichenbaum On the subject, would it be alright if I made the logger in App.xaml.cs a public property, and used it to log errors caught when loading the preview and/or details? This would make it much easier to debug issues such as this. |
@d2dyno1 I accidently tested on the release version instead of my local dev build. |
@d2dyno1 I know it's asking a lot, but could please clone this branch, do the same thing with it, then upload the log files afterwards? |
Sure, but I'll do it tomorrow |
The icon alignment is an issue with WinUI. |
@winston-de I've just tested your branch and it still doesn't work :( |
@d2dyno1 Yeah I didn't expect it to it's just some debugging stuff, could you upload the log file please? |
@winston-de Here it is: debug.txt |
@d2dyno1 Thanks. This is very interesting.
I have never seen this before, but I will see if I can fix it. |
Could it be because I'm running it in debug mode? |
@d2dyno1 This doesn't occur with the store version, correct? |
It does not. The store version works as intended. |
@d2dyno1 what build are you on? |
@d2dyno1 there dont seem to be any changes since 1.3 that changed that part of the code, so yes, I think this is an issue that occurs in debug mode. If you see this occur in a release build, please let me know. |
@duke7553 Is this specific to debug mode? |
Explain the bug
The details of file preview are not shown, only folder previews are displayed correctly. Additionally the UI of sound and video files is broken
Screenshots
Working (old):
Broken (new):
The text was updated successfully, but these errors were encountered: