upgrade to samba4

[nieder]

Samba3 had its last release 8 years ago.
Samba-4.17.x and 4.18.x hav some build failures (incomplete types), but 4.16.10 builds with only a few patches. However, it has problems with the install_name for the dylibs. Samba4 switched its build system to waf, which makes troubleshooting difficult. During the linking process, it never sets -install_name so all dylibs (which there are now over 50; many private in subdirs) use %b in the install_name. Fixing this post install will be very difficult.

The source has a file third_party/waf/waflib/Tools/ccroot.py that's getting read during the install, but the build is not going through the conditionals needed to set -install_name. I've tried a whole bunch of combinations there, but some earlier subprocesses are not being set the way it expects and so not everything gets named correctly. Specifically, the setting for inst_to around lines 637-639 seems broken. Maybe someone who knows python can debug it.

I'm attaching my .info and .patch files here so that they're not forgotten and maybe some one can figure it out.
samba4.info.txt
samba4.patch

[dmacks]

Would fixing all the install_name (and all the dyld links to them in all files) be sufficient, even though possibly complicated to do in practice? I don't know python, but several other packages have that sort of situation each with a hand-coded different solution, so I could try to hack together a general tool.