Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor bug #174

Open
gilesbradshaw opened this issue Apr 22, 2014 · 1 comment
Open

Minor bug #174

gilesbradshaw opened this issue Apr 22, 2014 · 1 comment

Comments

@gilesbradshaw
Copy link
Collaborator

To cope with parameterised urls

in p.init rather than ...

   if (parent.route && (parent.route[0] === m.getId() || (parent.route.length && m.getId() === '?') )) {

you need...

   if (parent.route && (parent.route[0].split('?')[0] === m.getId() || (parent.route.length && m.getId() === '?') )) {
@gilesbradshaw
Copy link
Collaborator Author

looking at this a bit more I think it should be

if (parent.route && parent.route.length && (parent.route[0].split('?')[0] === m.getId() || (parent.route.length && m.getId() === '?') )) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant