Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple active pages #216

Open
ramvis-imx opened this issue Oct 29, 2015 · 0 comments
Open

Multiple active pages #216

ramvis-imx opened this issue Oct 29, 2015 · 0 comments

Comments

@ramvis-imx
Copy link

Hello guys!

We have quite a big single page application. The problem is that sometimes Pager sets multiple pages as active. This can be reproduced when using sourceOnShow property in all pages and very quickly hitting menu items in the same level (without letting pages to load completely).

Because asynchronous callbacks Pager sometimes sets page as visible when it is no longer visible. For example when hitting a menu item, sourceOnShow request is made to server. At that moment we hit another menu item. Another sourceOnShow request is made to server. Now we have second menu item visible (active in the menu). But first sourceOnShow response from server arrives, Pager adds its HTML elements to DOM, creates bindings and founds another page with sourceOnShow and role=start in it. Creates third sourceOnShow request to server and when it is received and added to DOM, pager set a page as visible even if I have already navigated to another menu item.

The problem is that library do not check whether page's parent is active (or no more active) before showing it.

Simple check solves a problem.

image

Hope you add this fix to library and we will be able to continue use official version of your library. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant