Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TB] Shade color in dark mode is showing incorrect on-color #1003

Open
aaronreed708 opened this issue Aug 15, 2024 · 1 comment
Open

[TB] Shade color in dark mode is showing incorrect on-color #1003

aaronreed708 opened this issue Aug 15, 2024 · 1 comment
Labels
bug Something isn't working theme builder app Theme Builder application

Comments

@aaronreed708
Copy link
Contributor

aaronreed708 commented Aug 15, 2024

Problem/Concern

Saw this today when testing in preparation for release 1.2.0. I went to Components->Colors->Theme Colors. Notice that the on-color for the Secondary-600 shade is NOT #ffffff or #121212 (which I thought were the only possible values currently), but rather a completely different value. AND the text on that shade isn't visible so certainly the contrast is wrong. Not sure how that weird value is sneaking in there. Happens in both light and dark mode.

Notice that the on color and shade color are the same on that card.

Screenshot 2024-08-15 at 4 14 50 PM
@aaronreed708 aaronreed708 added bug Something isn't working theme builder app Theme Builder application labels Aug 15, 2024
@aaronreed708
Copy link
Contributor Author

Download this design system, load it into your Theme Builder and go to Components->Colors->Theme Colors

HasContastBug-design-system.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working theme builder app Theme Builder application
Projects
Status: High Priority
Development

No branches or pull requests

1 participant