Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] Add support to manage multiple themes in a design system #1054

Open
aaronreed708 opened this issue Nov 7, 2024 · 2 comments
Open

[SDK] Add support to manage multiple themes in a design system #1054

aaronreed708 opened this issue Nov 7, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request sdk Software development kit

Comments

@aaronreed708
Copy link
Contributor

Problem/Concern

This issue is to investigate, design and code how the SDK can manage multiple themes in a design system. Caller will need to be able to create a new named theme, query a named theme, update a named them and delete a named theme.

Some questions that may need to be answered:

  • How will naming be handled?
  • Will the UI need to prompt the user with a suggested name?

Proposed Solution

@aaronreed708 aaronreed708 added enhancement New feature or request sdk Software development kit labels Nov 7, 2024
@aaronreed708 aaronreed708 self-assigned this Nov 7, 2024
@aaronreed708
Copy link
Contributor Author

It looks like https://github.com/finos/a11y-theme-builder-sdk/blob/main/src/atoms/colorThemes.ts already supports multiple themes. So we would just need to call designSystem.atoms.colorThemes.createTheme to create a new theme and have it added to the set maintained by colorThemes.

@omesh-omg does this satisfy your needs? There doesn't appear to be a colorTheme deletion capability. We could maybe add support for that. Would you need that? Do we need to restrict and not allow the default theme to be deleted?

@aaronreed708
Copy link
Contributor Author

We also need to ensure that the generated JSON and CSS w.r.t. multiple themes will work with Figma as well as make sense and be consumable for a developer to is trying to use the design system. And in V2 where generation is strictly JSON, the JSON needs to have enough theme information in it to allow good CSS to be created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request sdk Software development kit
Projects
Status: No status
Development

No branches or pull requests

1 participant