Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] Button and icon do not have registered dependencies #1063

Open
aaronreed708 opened this issue Dec 7, 2024 · 0 comments
Open

[SDK] Button and icon do not have registered dependencies #1063

aaronreed708 opened this issue Dec 7, 2024 · 0 comments
Assignees
Labels
awaiting feedback Issue is blocked until awaiting feedback bug Something isn't working sdk Software development kit

Comments

@aaronreed708
Copy link
Contributor

Problem/Concern

Related to #1061. I noticed in that issue that the fact that gradient1 and gradient2 doesn't have values will prevent anyone from giving the colorTheme.button a new value. Yet, button and icon do not have gradient1 and gradient2 as dependencies. This seems like an oversight. I also believe that colorTheme.primary should be a dependency for button and icon.

We probably need to determine if this worked at one time or have button and icon never had dependencies? If not, is there a reason why not? @evangk6 or @lwnoble do you know?

Proposed Solution

@aaronreed708 aaronreed708 added bug Something isn't working sdk Software development kit awaiting feedback Issue is blocked until awaiting feedback labels Dec 7, 2024
@aaronreed708 aaronreed708 self-assigned this Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting feedback Issue is blocked until awaiting feedback bug Something isn't working sdk Software development kit
Projects
Status: No status
Development

No branches or pull requests

1 participant