Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bump plugin sample to v0.1.0, add to npm publish workflow #776

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: bump plugin sample to v0.1.0, add to npm publish workflow #776

wants to merge 4 commits into from

Conversation

coopernetes
Copy link
Contributor

closes #771

@netlify Netlify
Copy link

netlify bot commented Oct 30, 2024 •
edited
Loading

✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit 3573de3
🔍 Latest deploy log https://app.netlify.com/sites/endearing-brigadeiros-63f9d0/deploys/673266c6e7746e00089838b6

@coopernetes coopernetes added bug Something isn't working documentation Improvements or additions to documentation plugins Extensibility of the framework maintenance and removed feature labels Oct 30, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.12%. Comparing base (1e35b93) to head (3573de3).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #776   +/-   ##
=======================================
  Coverage   60.12%   60.12%           
=======================================
  Files          47       47           
  Lines        1650     1650           
=======================================
  Hits          992      992           
  Misses        658      658

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JamieSlome
Copy link
Member

@maoo @TheJuanAndOnly99 - are we okay to publish this sample NPM project?

@TheJuanAndOnly99
Copy link
Member

@maoo @TheJuanAndOnly99 - are we okay to publish this sample NPM project?

LGTM @JamieSlome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamieSlome JamieSlome Awaiting requested review from JamieSlome

Assignees
No one assigned
Labels
bug Something isn't working documentation Improvements or additions to documentation feature maintenance plugins Extensibility of the framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to visit or install @finos/git-proxy-plugin-samples mentioned in the documentation
3 participants
@coopernetes @JamieSlome @TheJuanAndOnly99