From 4323059893db64b3d16767d8e9c5cff97aff264f Mon Sep 17 00:00:00 2001 From: Onesimus Wiafe Date: Tue, 29 Oct 2024 13:36:17 +0000 Subject: [PATCH 1/2] fix treemap rendering issue in firefox Signed-off-by: Onesimus Wiafe --- .../src/ts/series/treemap/treemapSeries.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/perspective-viewer-d3fc/src/ts/series/treemap/treemapSeries.ts b/packages/perspective-viewer-d3fc/src/ts/series/treemap/treemapSeries.ts index 8715c0cb23..45439a09a3 100644 --- a/packages/perspective-viewer-d3fc/src/ts/series/treemap/treemapSeries.ts +++ b/packages/perspective-viewer-d3fc/src/ts/series/treemap/treemapSeries.ts @@ -70,8 +70,8 @@ export function treemapSeries() { const rects = nodesMerge .select("rect") .attr("class", (d) => `treerect ${nodeLevelHelper(maxDepth, d)}`) - .style("x", (d) => d.x0) - .style("y", (d) => d.y0) + .style("x", (d) => `${d.x0}px`) + .style("y", (d) => `${d.y0}px`) .style("width", (d) => calcWidth(d)) .style("height", (d) => calcHeight(d)); From a37e81e497599ecbcf8dfd024c422f689c9c9ba1 Mon Sep 17 00:00:00 2001 From: Onesimus Wiafe Date: Tue, 19 Nov 2024 10:30:44 +0000 Subject: [PATCH 2/2] include width and height to the fix Signed-off-by: Onesimus Wiafe --- .../src/ts/series/treemap/treemapSeries.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/perspective-viewer-d3fc/src/ts/series/treemap/treemapSeries.ts b/packages/perspective-viewer-d3fc/src/ts/series/treemap/treemapSeries.ts index 45439a09a3..1358ac0513 100644 --- a/packages/perspective-viewer-d3fc/src/ts/series/treemap/treemapSeries.ts +++ b/packages/perspective-viewer-d3fc/src/ts/series/treemap/treemapSeries.ts @@ -72,8 +72,8 @@ export function treemapSeries() { .attr("class", (d) => `treerect ${nodeLevelHelper(maxDepth, d)}`) .style("x", (d) => `${d.x0}px`) .style("y", (d) => `${d.y0}px`) - .style("width", (d) => calcWidth(d)) - .style("height", (d) => calcHeight(d)); + .style("width", (d) => `${calcWidth(d)}px`) + .style("height", (d) => `${calcHeight(d)}px`); rects.style("fill", (d) => { if (nodeLevelHelper(maxDepth, d) === nodeLevel.leaf) {