From 676f9a2c8679e0ce3946f3689a32aa5d349c24f8 Mon Sep 17 00:00:00 2001
From: Pragati <pragatimodi@google.com>
Date: Wed, 4 Oct 2023 13:14:38 -0400
Subject: [PATCH] add valid request tests

---
 test/unit/auth/passkey-config.spec.ts | 23 +++++++++++++++++------
 1 file changed, 17 insertions(+), 6 deletions(-)

diff --git a/test/unit/auth/passkey-config.spec.ts b/test/unit/auth/passkey-config.spec.ts
index f0b103b18d..f8c3887930 100644
--- a/test/unit/auth/passkey-config.spec.ts
+++ b/test/unit/auth/passkey-config.spec.ts
@@ -19,11 +19,9 @@ import * as chai from 'chai';
 import * as sinonChai from 'sinon-chai';
 import * as chaiAsPromised from 'chai-as-promised';
 import {
-    PasskeyConfig, PasskeyConfigRequest, PasskeyConfigServerResponse,
+    PasskeyConfig, PasskeyConfigRequest, PasskeyConfigServerResponse, PasskeyConfigClientRequest
   } from '../../../src/auth/passkey-config';
 import {deepCopy} from '../../../src/utils/deep-copy';
-import {ServerResponse} from 'http';
-import exp from 'constants';
 
 chai.should();
 chai.use(sinonChai);
@@ -42,6 +40,15 @@ describe('PasskeyConfig', () => {
     };
     describe('buildServerRequest', () => {
         describe('for a create request', () => {
+            const validRpId = 'project-id.firebaseapp.com';
+            it('should create a client request with valid params', () => {
+                const expectedRequest: PasskeyConfigClientRequest = {
+                    rpId: validRpId, 
+                    expectedOrigins: passkeyConfigRequest.expectedOrigins,
+                };
+                expect(PasskeyConfig.buildServerRequest(true, passkeyConfigRequest, validRpId)).to.deep.equal(expectedRequest);
+            });
+
             const invalidRpId = [null, NaN, 0, 1, '', [], [1, 'a'], {}, { a: 1 }, _.noop];
             invalidRpId.forEach((rpId) => {
                 it('should throw on invalid rpId {$rpId}', () => {
@@ -54,8 +61,14 @@ describe('PasskeyConfig', () => {
             it('should throw error if rpId is defined', () => {
                 expect(PasskeyConfig.buildServerRequest(false, passkeyConfigRequest, 'project-id.firebaseapp.com')).to.throw(`'rpId' must be a valid non-empty string'`);
             });
-        });
 
+            it('should create a client request with valid params', () => {
+                const expectedRequest: PasskeyConfigClientRequest = { 
+                    expectedOrigins: passkeyConfigRequest.expectedOrigins,
+                };
+                expect(PasskeyConfig.buildServerRequest(false, passkeyConfigRequest)).to.deep.equal(expectedRequest);
+            });
+        });
         
         describe('for passkey config request', () => {
             const nonObjects = [null, NaN, 0, 1, true, false, '', 'a', [], [1, 'a'], _.noop];
@@ -104,8 +117,6 @@ describe('PasskeyConfig', () => {
             expect(passkeyConfig.rpId).to.equal(expectedServerResponse.rpId);
             expect(passkeyConfig.expectedOrigins).to.equal(expectedServerResponse.expectedOrigins);
         });
-        
-
     });
 
     describe('toJSON', () => {