-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uncatchable throws in httpSession #2789
Comments
Hi @siakc thank you for filing this issue. Let me look into it. In the meantime, can you share any error logs you might have? |
Sure
It maybe helpful to note that the cause of the problem seemed to be a DNS misconfiguration on our side. |
Thanks for the additional context! |
This is correct. |
Maybe related, see logs in parse-community/parse-server-push-adapter#340 (comment). These errors started to appear about 4 weeks ago without code change. |
These type of network error are often not associated with any specific request. An error like
I think the http/2 implementation was an important step, but it now needs to be refined for robustness in order to be a viable alternative to the legacy http/1.1 connection. Until then, the issue can be avoided by not using http/2 with enableLegacyHttpTransport, which comes with the note:
I'd suggest that the SDK hasn't reached said stability yet without http/2 connection error remediation. |
If the error is not catchable by developer code because module code is doing stuff independenty (like by handling events or using timers), emitting events or accepting callbacks seem to be the appropriate mechanisms for giving a chance to developer to handle the errors in an asynchronous manner. |
Thanks folks, I think we can reject in a promise... something similar to: firebase-admin-node/src/utils/api-request.ts Line 643 in cb374ca
Let me also look into using |
@lahirumaramba if it helps, see parse-community/parse-server-push-adapter#341 for how we wrapped |
We were getting uncaught exceptions from this package (node version v14.21.3). After investigating the matter noticed we have
added in src/utils/api-request.ts (commit: e5001c1). Here when we throw errors in the callbacks there is no way we could catch it with a try...catch or .catch().
The text was updated successfully, but these errors were encountered: