Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Gradle AppDistributionPlugin should not eagerly create its tasks #6518

Open
bmuschko opened this issue Nov 14, 2024 · 4 comments
Open

The Gradle AppDistributionPlugin should not eagerly create its tasks #6518

bmuschko opened this issue Nov 14, 2024 · 4 comments

Comments

@bmuschko
Copy link

bmuschko commented Nov 14, 2024

[REQUIRED] Step 2: Describe your environment

[REQUIRED] Step 3: Describe the problem

Using the TaskContainer.create method to create a task will spend unnecessary time when running a Gradle build. You should use the TaskContainer.register method. For more information, see the Gradle documentation.

Steps to reproduce:

Simply apply and configure the plugin. Any UploadDistributionTask, AddTestersTask, and RemoveTestersTask tasks will be created and configured during Gradle's configuration phase.

BTW: Where do I find the source code of the Gradle plugin? It doesn't seem to live in this repository.

@google-oss-bot
Copy link
Contributor

I found a few problems with this issue:

  • I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.
  • This issue does not seem to follow the issue template. Make sure you provide all the required information.

@lehcar09
Copy link
Contributor

Hi @bmuschko, thank you for reaching out and suggesting how we can improve our Firebase SDK. I'll go ahead and mark this as a feature request. While we are unable to promise any timeline for this, we'll definitely keep this under our radar.

P.S. For folks who find this useful, adding an emoji thumbs up on the original post can help us prioritize adding this to the roadmap.

As for the Firebase App Distribution Gradle plugin source code, our engineers also aim for it to be open source, however, this is not the high priority at the moment.

@bmuschko
Copy link
Author

Thanks for the info, @lehcar09. Marking the issue as a feature request sounds reasonable. Let me know in case you are open sourcing the Gradle plugin. I'd be happy to provide a pull request.

@bmuschko
Copy link
Author

bmuschko commented Dec 3, 2024

@lehcar09 This issue already got 23 thumbs up. Is there a chance we can get it addressed soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants