Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package not compatible with firebase-admin 13 #246

Open
gigilibala opened this issue Nov 24, 2024 · 5 comments · May be fixed by #248
Open

package not compatible with firebase-admin 13 #246

gigilibala opened this issue Nov 24, 2024 · 5 comments · May be fixed by #248
Labels
type: bug Something isn't working

Comments

@gigilibala
Copy link

Version info

firebase-functions-test:

"firebase-functions-test": "^3.3.0",

firebase-functions:

"firebase-functions": "^6.1.1",

firebase-admin:

"firebase-admin": "^13.0.1",

Test case

Look below. the dependency is missing. This is failing our deployments.

Steps to reproduce

Quite obvious from peer dependency that firebase-admin 13 is missing:

  "peerDependencies": {
    "firebase-admin": "^8.0.0 || ^9.0.0 || ^10.0.0 || ^11.0.0 || ^12.0.0",
    "firebase-functions": ">=4.9.0",
    "jest": ">=28.0.0"
  },

Expected behavior

It should work with latest version of firebase-admin.

Actual behavior

Build failed with status: FAILURE and message: npm error code ERESOLVE
npm error ERESOLVE unable to resolve dependency tree
npm error
npm error While resolving: @cocomango/functions@undefined
npm error Found: [email protected]
npm error node_modules/firebase-admin
npm error   firebase-admin@"^13.0.1" from the root project
npm error
npm error Could not resolve dependency:
npm error peer firebase-admin@"^8.0.0 || ^9.0.0 || ^10.0.0 || ^11.0.0 || ^12.0.0" from [email protected]
npm error node_modules/firebase-functions-test
npm error   dev firebase-functions-test@"^3.3.0" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.

Please, fix. Thank you :)

@kdawgwilk
Copy link

You can always add an overrides and force install it for now

xylo04 added a commit to k0swe/forester that referenced this issue Dec 1, 2024
xylo04 added a commit to k0swe/forester that referenced this issue Dec 1, 2024
@mike-4040
Copy link

Simple overrides doesn't work, we also need peerDependenciesMeta:

  "peerDependenciesMeta": {
    "firebase-admin": {
      "optional": true
    }
  },
  "overrides": {
    "firebase-functions-test": {
        "firebase-admin": "^13.0.1"
    }
  }

@Matt-Jennings-GitHub Matt-Jennings-GitHub linked a pull request Dec 5, 2024 that will close this issue
@Matt-Jennings-GitHub
Copy link

Opened a PR with the peer dep update to firebase-admin 13. Not sure if this project is actively maintained but fingers crossed.

@mike-4040
Copy link

Thanks, approved, but my voice doesn't mean much.

@greg-md
Copy link

greg-md commented Dec 17, 2024

Still not resolved?

@CorieW CorieW added the type: bug Something isn't working label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants