Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop legacy import/export syntax #40

Open
merlinnot opened this issue Mar 11, 2019 · 3 comments
Open

Drop legacy import/export syntax #40

merlinnot opened this issue Mar 11, 2019 · 3 comments
Labels
priority: p1 type: enhancement New feature or request

Comments

@merlinnot
Copy link

This package uses legacy import/export syntax, the proposal was withdrawn and this syntax should not be used:

export = (firebaseConfig?: AppOptions, pathToServiceAccountKey?: string) => {

import fft = require('../../src/index');

We could either use default export, or preferably a named one, but it would be a breaking change, so I won't make a PR before we align on this.

@abeisgoat
Copy link
Contributor

Absolutely agreed, I'll probably snap this twig on the next major release.

@merlinnot
Copy link
Author

@abeisgoat Is this package still maintained? Is it worth to start making PRs?

@laurenzlong
Copy link
Contributor

Hey @merlinnot sorry for the long silence! We've definitely dropped the ball on our side, and will start showing this repo some more love. Yes you're very welcome to start making PRs, and we'd be happy to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p1 type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants