makeDocumentSnapshot check wrong option names.

[rharter]

makeDocumentSnapshot checks the options to see if there is an app property, but DocumentSnapshotOptions calls it firebaseApp. This leads to some weird casting requirements to use makeDocumentSnapshot with your own initialized app.

This issue is here.

firebase-functions-test/src/providers/firestore.ts

Line 58 in 22ba3d1

if (has(options, 'app')) {

[tettoffensive]

@rharter Since your pull request is kinda in the same area as the issue I'm experiencing (and I'm not seeing any other activity here) I thought I'd ask if your experiencing what I'm seeing in #87 where makeDocumentSnapshot doesn't work because it's trying to use .snapshot_

[rharter]

I haven't run into that, but I'm also not using the function from a class implementation, I've been using it statically and passing in my app, so I can't say it's not related.

[tettoffensive]

Thanks. I tried it statically and get the same error. It seems to me that makeDocumentSnapshot relies on the Node.js Server SDK for Google Cloud Firestore. So it doesn't work when testing the Node.js client for Firestore despite what the documentation says.