From e31679f23bc0dce1ea253f64da2542d08db1646e Mon Sep 17 00:00:00 2001 From: cherylEnkidu Date: Tue, 12 Nov 2024 15:38:40 -0800 Subject: [PATCH] Revert "use @_implementationOnly" This reverts commit 4164fb9b01e17889e1d95757b3d11ee38ac94e0c. --- Firestore/Swift/Source/SwiftAPI/SwiftCppAPI.swift | 4 ++-- Package.swift | 10 ++++++++-- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/Firestore/Swift/Source/SwiftAPI/SwiftCppAPI.swift b/Firestore/Swift/Source/SwiftAPI/SwiftCppAPI.swift index 8797915cc68..fafeec43e98 100644 --- a/Firestore/Swift/Source/SwiftAPI/SwiftCppAPI.swift +++ b/Firestore/Swift/Source/SwiftAPI/SwiftCppAPI.swift @@ -15,11 +15,11 @@ */ #if SWIFT_PACKAGE - @_implementationOnly import FirebaseFirestoreCpp + @_exported import FirebaseFirestoreCpp #endif // SWIFT_PACKAGE public class SwiftCallingCpp { - public static func print(_ value: String) { + public init(_ value: String) { CppInterfaceCalledBySwift.print(std.string(value)) } } diff --git a/Package.swift b/Package.swift index a4a1071802c..5a2b73deccf 100644 --- a/Package.swift +++ b/Package.swift @@ -476,7 +476,10 @@ let package = Package( dependencies: [ "FirebaseFirestoreTarget", ], - path: "FirebaseCombineSwift/Sources/Firestore" + path: "FirebaseCombineSwift/Sources/Firestore", + swiftSettings: [ + .interoperabilityMode(.Cxx), // C++ interoperability setting + ] ), .target( name: "FirebaseStorageCombineSwift", @@ -1171,7 +1174,10 @@ let package = Package( "FirebaseStorage", .product(name: "nanopb", package: "nanopb"), ], - path: "SwiftPMTests/swift-test" + path: "SwiftPMTests/swift-test", + swiftSettings: [ + .interoperabilityMode(.Cxx), // C++ interoperability setting + ] ), .testTarget( name: "analytics-import-test",