Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR]: Add CI to catch new public headers to Firestore #11971

Closed
ncooke3 opened this issue Oct 20, 2023 · 1 comment · Fixed by #12575
Closed

[FR]: Add CI to catch new public headers to Firestore #11971

ncooke3 opened this issue Oct 20, 2023 · 1 comment · Fixed by #12575

Comments

@ncooke3
Copy link
Member

ncooke3 commented Oct 20, 2023

Description

In #11954, the Firestore podspec was changed to include Swift code and headers that re-export public headers from an underlying FirebaseFirestoreInternal module. For each public header in the FirebaseFirestoreInternal module, there is a public header Firestore to export it. This can get out of sync so there are two options:

  • Generate these re-exporting headers as a pre-build command
  • Add a CI job to warn the PR author to add/remove a re-exporting header

API Proposal

No response

Firebase Product(s)

Firestore

@morganchen12
Copy link
Contributor

We added a similar check to prevent new public headers not being correctly added to the umbrella header via Danger: https://github.com/firebase/firebase-ios-sdk/blob/master/Dangerfile#L204

Maybe this could be applicable here as well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants