From 2e042ba79f0250fd0fb3b7dfcfe07f1fd4d81cad Mon Sep 17 00:00:00 2001 From: Russell Wheatley Date: Fri, 24 Jan 2025 12:34:19 +0000 Subject: [PATCH] feat: bump firebase iOS SDK to `v11.7.0` (#17011) * feat: bump firebase iOS SDK to `v11.7.0` * test: reintroduce skipped tests --- .../firebase_core/ios/firebase_sdk_version.rb | 2 +- .../firebase_auth/firebase_auth_instance_e2e_test.dart | 9 ++------- .../firebase_auth/firebase_auth_user_e2e_test.dart | 5 +---- 3 files changed, 4 insertions(+), 12 deletions(-) diff --git a/packages/firebase_core/firebase_core/ios/firebase_sdk_version.rb b/packages/firebase_core/firebase_core/ios/firebase_sdk_version.rb index ad6b28a96c64..723ebf4bcd20 100644 --- a/packages/firebase_core/firebase_core/ios/firebase_sdk_version.rb +++ b/packages/firebase_core/firebase_core/ios/firebase_sdk_version.rb @@ -1,4 +1,4 @@ # https://firebase.google.com/support/release-notes/ios def firebase_sdk_version!() - '11.6.0' + '11.7.0' end diff --git a/tests/integration_test/firebase_auth/firebase_auth_instance_e2e_test.dart b/tests/integration_test/firebase_auth/firebase_auth_instance_e2e_test.dart index ab31383af469..c013ac183f82 100644 --- a/tests/integration_test/firebase_auth/firebase_auth_instance_e2e_test.dart +++ b/tests/integration_test/firebase_auth/firebase_auth_instance_e2e_test.dart @@ -904,13 +904,8 @@ void main() { Exception e = await getError(); expect(e, isA()); - // Exception code is returning internal-error but the underlying error is "identitytoolkit.getRecaptchaConfig is not implemented in the Auth Emulator." - // This issue on firebase-ios-sdk: https://github.com/firebase/firebase-ios-sdk/issues/14242. Once this is resolved, we ought to reinstate the below. - // It works fine on live project but returns internal-error on emulator. - if (defaultTargetPlatform != TargetPlatform.iOS) { - FirebaseAuthException exception = e as FirebaseAuthException; - expect(exception.code, equals('invalid-phone-number')); - } + FirebaseAuthException exception = e as FirebaseAuthException; + expect(exception.code, equals('invalid-phone-number')); }); test( diff --git a/tests/integration_test/firebase_auth/firebase_auth_user_e2e_test.dart b/tests/integration_test/firebase_auth/firebase_auth_user_e2e_test.dart index e23c6f5f6bf9..849675dce7eb 100644 --- a/tests/integration_test/firebase_auth/firebase_auth_user_e2e_test.dart +++ b/tests/integration_test/firebase_auth/firebase_auth_user_e2e_test.dart @@ -251,10 +251,7 @@ void main() { }, skip: kIsWeb || defaultTargetPlatform == TargetPlatform.macOS || - defaultTargetPlatform == TargetPlatform.windows - // on iOS, returning an exception but underlying exception is: "identitytoolkit.getRecaptchaConfig is not implemented in the Auth Emulator." - // which might be a result of this issue: https://github.com/firebase/firebase-ios-sdk/issues/14242. Once resolved, try to reinstate. - || defaultTargetPlatform == TargetPlatform.iOS, + defaultTargetPlatform == TargetPlatform.windows, ); // verifyPhoneNumber not supported on web. test(