Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Executable prompts implementation is a mess and needs refactoring #1533

Closed
pavelgj opened this issue Dec 17, 2024 · 1 comment
Closed

Executable prompts implementation is a mess and needs refactoring #1533

pavelgj opened this issue Dec 17, 2024 · 1 comment
Milestone

Comments

@pavelgj
Copy link
Collaborator

pavelgj commented Dec 17, 2024

I know because I implemented it... :P

There are inconsistencies between underlying definePrompt and defineDotprompt implementations and some features are partially supported under the ai.definePrompt umbrella. Some inconsistencies are worked around with hacks where it requires a deeper refactoring.

@MichaelDoyle
Copy link
Member

Can I also make an appeal to have separate trace spans for render and generate? :) We started down this path for dotprompt, and it was quite nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants