Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashlytics iOS Documentation Issue [Legacy/New Build System, Last Build Script] #1090

Open
stolyarenkokswing opened this issue Nov 25, 2020 · 3 comments

Comments

@stolyarenkokswing
Copy link

stolyarenkokswing commented Nov 25, 2020

Problem Description:

Crashlytics documentation has a note in step 3 about fact that we need to be sure that the new run script will be run as the last build script.

Step 3: Initialize Crashlytics
Note: Make sure your new build phase is the project's last build phase or Crashlytics can't initialize properly.
https://firebase.google.com/docs/crashlytics/get-started

We can guarantee this only with the Legacy Build System, but on New Build System this phase may not necessarily be the last one.
https://medium.com/xcblog/five-things-you-must-know-about-xcode-10-new-build-system-41676cd5fd6c

Conclusion:

If you have already updated the code and it works correctly on the New Build System, please let us know and update the documentation.

If the code does not work correctly on a New Build System, please indicate in the documentation that only the Legacy Build System should be used, since only in it we can guarantee that the script will be executed last.

@stolyarenkokswing stolyarenkokswing changed the title iOS Crashlytics Documentation Issue [Legacy/New Build System] Crashlytics iOS Documentation Issue [Legacy/New Build System] Nov 25, 2020
@stolyarenkokswing stolyarenkokswing changed the title Crashlytics iOS Documentation Issue [Legacy/New Build System] Crashlytics iOS Documentation Issue [Legacy/New Build System, Last Build Script] Nov 25, 2020
@morganchen12
Copy link
Contributor

Thanks for the heads up. The Crashlytics scripts should work correctly with the new build system, though the docs may need to be updated.

@stolyarenkokswing
Copy link
Author

stolyarenkokswing commented Nov 30, 2020

Ok, thanks for the quick response!
Then, as I understand correctly, if we provide input files and execute the necessary scripts on a new build system without taking into account the note in the documentation that the scripts must be executed last - everything will work correctly?

@morganchen12
Copy link
Contributor

They really only need to be executed after the binary compilation is finished and the dSYMs have been generated, according to my knowledge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants