-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Go compiler support policy #95
Comments
Since firectl is a binary and not a library, I think we can be pretty aggressive about which go versions we support. |
Discussion with @Kern-- offline, the pipeline is experiencing some build repro issues even with my attempt at a pinning versions, #93, because of the |
Agreed, my first instinct as a user when it comes to this package is to use the binary. One of my pain points as a user of this package in the past was out of date binaries (rather, incompatible with latest versions of Firecracker) and having to clone/build myself. My opinion is to be aggressive with Go versions we support, and after that decision/upgrade in supported versions, release v0.2.0 as a fast follow to address #82 |
Upgrading Go compiler is currently limited by buildkite instances pinned to Go1.15 for minimum firecracker-go-sdk validation. For firectl, would a docker build solution be attractive so we can push the boundary on compiler versions? CC: @ginglis13, @Kern-- |
Personally, I think it would be better to get our CI infrastructure to run with docker rather than use make targets that use docker, but I'm open to discussion on that. For now, I think it's ok to update the buildkite hosts to just use Go 1.17. |
Would make just use the local Go installation? |
This thread is to host some discussion on compiler support for the firectl tool.
The text was updated successfully, but these errors were encountered: