Translation of delivery_time label

[DanieliMi]

General

• Module version: 2.0.1
• Magento version: 2.2.6
• PHP version: 7.0.32

Issue description

The translation of the label for delivery time is managed over the dictionary translation as of #74. But isn't it better to stay closer to magento and use the Manage Labels functionality?

The label here needs to be changed to "default" in order to use magentos functionality.

[amenk]

Not to confuse with #80

[amenk]

vendor/firegento/magesetup2/view/frontend/templates/product/list/delivery.phtml:25

if ($_attributeLabel && $_attributeLabel == 'default') {
     $_attributeLabel = $_product->getResource()->getAttribute($_code)->getFrontendLabel();
}

I found this code ... it looks like in

vendor/firegento/magesetup2/view/frontend/layout/catalog_delivery_info.xml:14

we just have to use the label "default" and it would work?

Why not just set this default as default?

[codedge]

This still is an issue in the recent version :(

[itsolon]

Is there any update.?
i have Delivery Time at product listing activated, but doing so .. no translate csv is drawn wherever i try to put the text in
i tried, in attribute itself
in i18n folder from vendor firegento already is the text inside works only for prodcut detail page
in i18n from my template as last measure does not work
thats all
i could alter the file delivery
the easiest way is to switch of this functionality
but you worked it in so lets perhaps use it?

I know you seo freaks out there you think now .. if he switches on then the seo strength of my keywors is washed out because of the use of hundreds delivery time haha.
best Regards
Markus

[sprankhub]

I tend to replace "Delivery Time" here:

firegento-magesetup2/view/frontend/layout/catalog_product_view.xml

Line 16 in fbcf4e2

<argument name="at_label" xsi:type="string" translate="true">Delivery Time</argument>

with default, so that the label comes from the backend. However, this could mean that many German shops have the word in English on their product page after the next MageSetup update. They would need to manually change the label in the backend. I am fine with it, but I do not want to decide it on my own :) @firegento/magesetup2-maintainers, what do you think?

[frostblogNet]

I`m fine with that too.