Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MULT DX, DY, DZ values do not match MESH XB values. #91

Open
marcosvanella opened this issue Sep 25, 2024 · 5 comments
Open

MULT DX, DY, DZ values do not match MESH XB values. #91

marcosvanella opened this issue Sep 25, 2024 · 5 comments

Comments

@marcosvanella
Copy link

Ciao Ema, this is from an issue in fds #13479 (firemodels/fds#13479) . The FDS mesh written for the case in the issue is:


&MULT ID='Meshes'
      DX=346.59 I_LOWER=0 I_UPPER=4
      DY=278.26 J_LOWER=0 J_UPPER=7 /
&MESH IJK=34,27,33 MULT_ID='Meshes'
      XB=-866.59,-520.01,-1113.01,-834.76,211.57,543.35 /

The values of DX and DY do not match exactly the XMAX-XMIN, YMAX-YMIN being written (they differ by the last digit). Turns out this difference make distance among meshes to increase as you set more meshes in X,Y. This is leading to issues matching meshes.
Can we make sure these numbers match when written?
Thanks!
M

@ericvmueller
Copy link
Collaborator

ericvmueller commented Sep 25, 2024

Is this the same as here #57? Did that fix ever make it into the main branch?
Edit: Ah yeah I see it did, but maybe it is the number of digits in the rounding?

@johodges
Copy link
Collaborator

My understanding is the main branch is still behind the dev branch. That fix is in place on dev but the user may be using main.

@emanuelegissi
Copy link
Member

emanuelegissi commented Sep 26, 2024

Yes, the last release is behind the dev branch, this is why the fix didn't get to the users.
I will sync that asap.

@3dfirelab
Copy link

I was using version 1.0.2
from the qgisinstallation plugin.
So no need to share with you my qgis project?

@emanuelegissi
Copy link
Member

No need to share the project. The issue is known and fixed in the dev version. I shall only release a newer version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants