Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Requests aren't reflecting my changes #30734

Closed
ghost opened this issue Sep 16, 2020 · 9 comments
Closed

Pull Requests aren't reflecting my changes #30734

ghost opened this issue Sep 16, 2020 · 9 comments

Comments

@ghost
Copy link

ghost commented Sep 16, 2020

🐞 Problem

I have followed all the steps to making a contribution

  • Forked this repo
  • Cloned it to my system
  • Created a branch
  • Added my name in contributors file
  • Committed my changes
  • Pushed the changes to my branch
  • Created a PR(Here is where the problem lies)
  • The comparison should be between the firstcontributions/firstcontributions repo and the master branch and KarenEfereyan/firstcontributions and the add-Karen-Efereyan branch which is ny forked repo. When the changes were set like this, I was unable to see the create PR button. Until I compared across KarenEfereyan/firstcontributions, master and KarenEfereyan/firstcontributions, add-Karen-Efereyan.
    It shoudn't be like that, should it?
    Because my changes aren't reflecting in the Contributors.md file

🎯 Goal

💡 Possible solutions

📋 Steps to solve the problem

  • Comment below about what you've started working on.
  • Add, commit, push your changes.
  • Submit a pull request and add this in comments - Addresses #<put issue number here>
  • Ask for reviews in comments section of pull request.
  • Celebrate your contribution to this project. 🎉
@Roshanjossey
Copy link
Member

@karenefereyan, I found the problem. You created the fork before April this year. After that we did a reset to reduce the size of the repo. Because of this, the commit history of this repo and your fork is different and can't compare branches.

To solve this problem, please delete your fork and fork it again

@ghost
Copy link
Author

ghost commented Sep 17, 2020

Will that solve it or do i need to delete the fork of the repo entirely?

@Roshanjossey
Copy link
Member

do i need to delete the fork of the repo entirely.

Yes, that's what I suggested please delete your fork and fork it again

@ghost
Copy link
Author

ghost commented Sep 17, 2020

Will do just that @Roshanjossey thank you

@Roshanjossey
Copy link
Member

I've created #30831 to collect common problems.

Closing this issue in favor of that one.

@Mannyflow7
Copy link

🐞 Problem

I have followed all the steps to making a contribution

  • Forked this repo
  • Cloned it to my system
  • Created a branch
  • Added my name in contributors file
  • Committed my changes
  • Pushed the changes to my branch
  • Created a PR(Here is where the problem lies)
  • The comparison should be between the firstcontributions/firstcontributions repo and the master branch and KarenEfereyan/firstcontributions and the add-Karen-Efereyan branch which is ny forked repo. When the changes were set like this, I was unable to see the create PR button. Until I compared across KarenEfereyan/firstcontributions, master and KarenEfereyan/firstcontributions, add-Karen-Efereyan.
    It shoudn't be like that, should it?
    Because my changes aren't reflecting in the Contributors.md file

🎯 Goal

💡 Possible solutions

📋 Steps to solve the problem

  • Comment below about what you've started working on.
  • Add, commit, push your changes.
  • Submit a pull request and add this in comments - Addresses #<put issue number here>
  • Ask for reviews in comments section of pull request.
  • Celebrate your contribution to this project. 🎉

@Mannyflow7
Copy link

@karenefereyan, I found the problem. You created the fork before April this year. After that we did a reset to reduce the size of the repo. Because of this, the commit history of this repo and your fork is different and can't compare branches.

To solve this problem, please delete your fork and fork it again

@Mannyflow7
Copy link

Will that solve it or do i need to delete the fork of the repo entirely?

@Mannyflow7
Copy link

Will do just that @Roshanjossey thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants