Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio: Play sound on player death #986

Closed
MaxCWhitehead opened this issue Apr 22, 2024 · 8 comments · Fixed by #1046
Closed

Audio: Play sound on player death #986

MaxCWhitehead opened this issue Apr 22, 2024 · 8 comments · Fixed by #1046
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@MaxCWhitehead
Copy link
Collaborator

Description

Would be good to have some audio feedback on player dying.

Alternatives & Prior Art

No response

@reemhashir1
Copy link

My team and I are doing a software engineering project as part of a class at Carnegie Mellon University. Is this issue something we can work on? If so, could you please assign this to us? Thank you so much!

@elliay @dksung101 @LawrenceZLee @yiyao625

@erlend-sh
Copy link
Member

Sure, give it a go :) this is a one-person job though, heh. (And github only lets us assign people who’ve replied to the thread)

@elliay
Copy link
Contributor

elliay commented Nov 23, 2024

We've never worked with rust before, so it will be a learning experience! Can you assign me as well? Thank you!

@erlend-sh erlend-sh added help wanted Extra attention is needed good first issue Good for newcomers labels Nov 23, 2024
@MaxCWhitehead
Copy link
Collaborator Author

MaxCWhitehead commented Nov 24, 2024

@elliay @reemhashir1

Please let me know if you have questions after exploring how to run the game, how to add a sound effect, or play it from code. Looking at how the player jump sound is setup would be a good reference for how audio is triggered.

I think this is a definitely an accomplish-able task, but I would definitely expect you may have have questions - so please do ask if they come up. Happy to support.

The easiest place to ask questions would be on our discord (https://discord.com/invite/4smxjcheE5). Can ask in the "jumpy" channel, and optionally ping me @max. But communicating here is great too.

A good first step would be running the game and seeing what death currently looks like :)

@reemhashir1
Copy link

Hey! We are currently deciding between two sounds for the character death. Please let me know which sound you approve of! Thank you for your quick responses. We truly appreciate it :) These are the links.
https://pixabay.com/sound-effects/8-bit-video-game-fail-version-2-145478/

https://pixabay.com/sound-effects/8-bit-video-game-lose-sound-version-4-145477/

@erlend-sh
Copy link
Member

erlend-sh commented Dec 2, 2024

That seems more like a ‘Game Over’ sound.

A player death sound should be shorter and simpler. Some examples here: #924

You can use this sound, or find something similar to it: https://freesound.org/people/Reitanna/sounds/252255/

@reemhashir1
Copy link

reemhashir1 commented Dec 2, 2024

I understand. How does this sound? https://freesound.org/people/brittmosel/sounds/529300/ or we can stick to the one you suggested.

@erlend-sh
Copy link
Member

That one’s good!👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants